Skip to content

Bob: Add test case for shouting statement with question mark not at end.#2661

Open
jack-garratt wants to merge 2 commits into
exercism:mainfrom
jack-garratt:patch-1
Open

Bob: Add test case for shouting statement with question mark not at end.#2661
jack-garratt wants to merge 2 commits into
exercism:mainfrom
jack-garratt:patch-1

Conversation

@jack-garratt

Copy link
Copy Markdown

The previous test cases would consider any shouting statement with a question mark to be a shouting question. This is not the case as a question must end with a question mark. This test case covers this scenario.

@github-actions

Copy link
Copy Markdown
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions Bot closed this Jun 16, 2026
@IsaacG

IsaacG commented Jun 16, 2026

Copy link
Copy Markdown
Member

@IsaacG IsaacG reopened this Jun 16, 2026
Comment thread exercises/bob/canonical-data.json Outdated
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
@jack-garratt

Copy link
Copy Markdown
Author

I have updated the description to fully lowercase.
The failure seems to be unrelated to the changes made so not sure why that's failing?

@IsaacG

IsaacG commented Jun 17, 2026

Copy link
Copy Markdown
Member

Ignore that CI failure. It's unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants