Skip to content

Sync Sum of multiples (issue #1021)#1024

Merged
mk-mxp merged 5 commits into
exercism:mainfrom
resu-xuniL:sync-sum-of-multiples
Jul 13, 2026
Merged

Sync Sum of multiples (issue #1021)#1024
mk-mxp merged 5 commits into
exercism:mainfrom
resu-xuniL:sync-sum-of-multiples

Conversation

@resu-xuniL

@resu-xuniL resu-xuniL commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Sync Sum of multiples (issue #986)

  • Synced Sum of multiples metadata and docs
  • Removed strict types comments from example.php and SumOfMultiplesTest.php
  • Added sum-of-multiples to auto-sync.txt
  • Added GitHub handle to config.json
  • Added tests, UUID and TestDox

[no important files changed]

Ref: #1021

@github-actions

Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure the additional tests will make some student solutions fail. But that's OK, I think.

Thank you!

@mk-mxp
mk-mxp merged commit eaa992f into exercism:main Jul 13, 2026
15 checks passed
@resu-xuniL
resu-xuniL deleted the sync-sum-of-multiples branch July 13, 2026 18:25
@resu-xuniL

Copy link
Copy Markdown
Contributor Author

My pleasure.

@resu-xuniL

resu-xuniL commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@mk-mxp : If I do exercism download --force --track=php --exercise=sum-of-multiples, the SumOfMultiplesTest.php is not updated. What's wrong ?

@mk-mxp

mk-mxp commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

If I remember correctly, you must update the exercise via the website first. Maybe you also need to open the online editor and run the tests once. I don't use the download anymore, so don't rely on it.

@resu-xuniL

Copy link
Copy Markdown
Contributor Author

If I remember correctly, you must update the exercise via the website first. Maybe you also need to open the online editor and run the tests once. I don't use the download anymore, so don't rely on it.

OK, that was it: as my solution was broken with the new tests, I had to update via the website first. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants