SMC: fixes case values for SP4B and SP69 in smc.swift#2894
Merged
exelban merged 1 commit intoexelban:masterfrom Jan 11, 2026
Merged
SMC: fixes case values for SP4B and SP69 in smc.swift#2894exelban merged 1 commit intoexelban:masterfrom
exelban merged 1 commit intoexelban:masterfrom
Conversation
Signed-off-by: Carter Li <CarterLi@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes two typos in the SMCDataType enum raw values where the string values didn't match their corresponding enum case names, aligning them with the established naming pattern in the enum.
- SP4B raw value corrected from "sp5b" to "sp4b"
- SP69 raw value corrected from "sp669" to "sp69"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
LGTM, thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.