🧪 Convert normalize_doctree_xml to pytest fixture#1090
Merged
chrisjsewell merged 4 commits intomasterfrom Jan 19, 2026
Merged
Conversation
Co-authored-by: chrisjsewell <2997570+chrisjsewell@users.noreply.github.com>
Co-authored-by: chrisjsewell <2997570+chrisjsewell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make normalize_doctree_xml a pytest fixture
Convert normalize_doctree_xml to pytest fixture
Jan 19, 2026
Co-authored-by: chrisjsewell <2997570+chrisjsewell@users.noreply.github.com>
Contributor
Author
Fixed in dab28f2. Applied ruff formatting to function signatures that exceeded line length limits. |
chrisjsewell
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed: Convert normalize_doctree_xml to pytest fixture
Summary
Successfully converted
normalize_doctree_xmlfrom a standalone function to a pytest fixture. Tests no longer need to import it - they can now use it directly as a fixture parameter.Changes Made
normalize_doctree_xmlto a pytest fixture intests/conftest.py@pytest.fixturedecoratornormalize_doctree_xmlacross test files (9 files)normalize_doctree_xmlas a fixture parameterFiles Modified
tests/conftest.py- Converted function to fixture, applied formattingtests/test_sphinx/conftest.py- Removed import, added fixture parameter toget_sphinx_app_doctreetests/test_html/test_html_to_nodes.py- Removed import, added fixture parametertests/test_renderers/test_fixtures_docutils.py- Removed import, added fixture parameter to 5 test functions, applied formattingtests/test_renderers/test_myst_refs.py- Removed import, added fixture parametertests/test_renderers/test_myst_config.py- Removed import, added fixture parametertests/test_renderers/test_include_directive.py- Removed import, added fixture parametertests/test_renderers/test_fixtures_sphinx.py- Removed import, added fixture parameter to 11 test functions, applied formattingtests/test_sphinx/test_sphinx_builds.py- Removed import, added fixture parameterTesting
normalize_doctree_xmlremain in test filesOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.