feat: allow passing kernel manager to parser#721
Open
flying-sheep wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I built sphinx-exec-jupyter to leverage myst-nb’s machinery for running code blocks in isolation.
In it, I’m using a custom
KernelClientfor efficiency.This client needs to be passed down all the way to
executenb, and it would be great if that was possible without monkeypatchingmyst-nb.Usage
It can be used directly when using a
Parserprogrammaticly:… or by overriding the registered parser in a Sphinx extension like this:
Possible alternatives
Instead of adding the
kmproperty to the parser and passing them tocreate_client, we could wrapcreate_clientinto a method onParser, then I could override it. The other changes would still be necessary.In addition to the above method, I could break up
parseinto more granular steps in general for easier extensibility.