Update infrastructure for new pythons and prep for latest sphinx #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
changed the title
bsipocz
previously approved these changes
Jan 17, 2026
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
This PR is in a better shape than mine, so would merge this first and the do a bit more CI cleanup and dropping of old python.
I have a few comments that I'll commit directly, and will add back an oldest supported job, too. Once CI is all green will go ahead with the merge.
Thank you Chris!
Comment on lines
-42
to
-47
| # Oldest known-compatible dependencies | ||
| - os: ubuntu-latest | ||
| python-version: "3.9" | ||
| sphinx: "==5.0.0" | ||
| myst-parser: "==1.0.0" | ||
| pillow: "==11.0.0" |
Member
There was a problem hiding this comment.
I think we need to keep an "oldest" job around otherwise won't really spot when we silently drop support
…rements and tox configs
bsipocz
reviewed
Jan 17, 2026
| sphinx: "==5.0.0" | ||
| myst-parser: "==1.0.0" | ||
| pillow: "==11.0.0" | ||
| # Mid-range dependencies |
Member
There was a problem hiding this comment.
Keeping the oldest job
Suggested change
| # Mid-range dependencies | |
| # Oldest known-compatible dependencies | |
| - os: ubuntu-latest | |
| python-version: "3.9" | |
| sphinx: "==5.0.0" | |
| myst-parser: "==1.0.0" | |
| pillow: "==11.0.0" | |
| # Mid-range dependencies |
bsipocz
changed the title
Member
|
All the test jobs are pinning sphinx <9 or fail, so I added the upper pin for now. |
bsipocz
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some prep work for the new version of Sphinx, though doesn't test for it yet because a bunch of other dependencies in the stack still don't support it. So this is mostly some prep work, and the python versions shouldn't be a problem.
I think the biggest changes are: