Skip to content

chore: re-add development replaces #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julienrbrt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: re-add development replaces #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/evm/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ module github.com/evstack/ev-node/apps/evm

go 1.25.7

// replace (
// github.com/evstack/ev-node => ../../
// github.com/evstack/ev-node/execution/evm => ../../execution/evm
// )
replace (
github.com/evstack/ev-node => ../../
github.com/evstack/ev-node/execution/evm => ../../execution/evm
)
Comment on lines +5 to +8
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check replace directive consistency and workspace configuration

echo "=== Checking if go.work exists ==="
if [ -f "go.work" ]; then
  echo "✓ go.work exists - workspace mode is active (replace directives below are ignored)"
  cat go.work
else
  echo "✗ go.work does not exist - replace directives are active"
fi

echo -e "\n=== Finding all go.mod files ==="
fd -t f '^go\.mod$'

echo -e "\n=== Checking replace directives in all go.mod files ==="
fd -t f '^go\.mod$' --exec sh -c 'echo "--- {} ---"; grep -A 5 "^replace" {} || echo "No replace directives found"'

echo -e "\n=== Checking requires for ev-node modules ==="
rg -n "^\s*github\.com/evstack/ev-node" -g 'go.mod' --no-heading

Repository: evstack/ev-node

Length of output: 5502

Add missing replace directive for github.com/evstack/ev-node/core.

This module requires github.com/evstack/ev-node/core v1.0.0 (line 13) but lacks a replace directive for it, unlike the replaces for ev-node and ev-node/execution/evm (lines 6-7). This causes the core module to resolve to the published version while other submodules use local code, potentially creating version conflicts if the local ev-node depends on unreleased changes to core.

Add a replace directive for core:

replace github.com/evstack/ev-node/core => ../../core

Note: This pattern is consistent across modules in the monorepo (apps/grpc, apps/testapp, etc.). Consider whether this is intentional or should be systematically addressed across all modules.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/evm/go.mod` around lines 5 - 8, Add a replace directive for the local
core module so the go.mod's replace block points the dependency
github.com/evstack/ev-node/core to the local folder; specifically, update the
replace block that currently contains github.com/evstack/ev-node and
github.com/evstack/ev-node/execution/evm to also include
github.com/evstack/ev-node/core => ../../core so the core dependency resolves to
the local source rather than the published v1.0.0.


require (
github.com/ethereum/go-ethereum v1.17.2
Expand Down
4 changes: 0 additions & 4 deletions apps/evm/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,12 +472,8 @@ github.com/ethereum/go-bigmodexpfix v0.0.0-20250911101455-f9e208c548ab h1:rvv6MJ
github.com/ethereum/go-bigmodexpfix v0.0.0-20250911101455-f9e208c548ab/go.mod h1:IuLm4IsPipXKF7CW5Lzf68PIbZ5yl7FFd74l/E0o9A8=
github.com/ethereum/go-ethereum v1.17.2 h1:ag6geu0kn8Hv5FLKTpH+Hm2DHD+iuFtuqKxEuwUsDOI=
github.com/ethereum/go-ethereum v1.17.2/go.mod h1:KHcRXfGOUfUmKg51IhQ0IowiqZ6PqZf08CMtk0g5K1o=
github.com/evstack/ev-node v1.1.0-rc.2 h1:7fdGpzjJwtNLtLJJ/Fyj2yFv5ARKnMAPh22Z5cRd1r0=
github.com/evstack/ev-node v1.1.0-rc.2/go.mod h1:5lIACV0hQGO5Btdb1b3fSw2Vz7Jvrg2yvMefalfWguA=
github.com/evstack/ev-node/core v1.0.0 h1:s0Tx0uWHme7SJn/ZNEtee4qNM8UO6PIxXnHhPbbKTz8=
github.com/evstack/ev-node/core v1.0.0/go.mod h1:n2w/LhYQTPsi48m6lMj16YiIqsaQw6gxwjyJvR+B3sY=
github.com/evstack/ev-node/execution/evm v1.0.1 h1:cpFCcrAajTRoptAaSbaqkU6bIRc7hnmXK346zwqk/Lo=
github.com/evstack/ev-node/execution/evm v1.0.1/go.mod h1:QEmT3dKWvzdsUs/Nkt7Cqd3fWTUFpzezTQoWw3MpHMw=
github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
github.com/fatih/color v1.10.0/go.mod h1:ELkj/draVOlAH/xkhN6mQ50Qd0MPOk5AAr3maGEBuJM=
github.com/fatih/color v1.13.0/go.mod h1:kLAiJbzzSOZDVNGyDpeOxJ47H46qBXwg5ILebYFFOfk=
Expand Down
2 changes: 1 addition & 1 deletion apps/testapp/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/evstack/ev-node/apps/testapp

go 1.25.7

// replace github.com/evstack/ev-node => ../../.
replace github.com/evstack/ev-node => ../../.

require (
github.com/evstack/ev-node v1.1.0-rc.2
Expand Down
2 changes: 0 additions & 2 deletions apps/testapp/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,6 @@ github.com/envoyproxy/protoc-gen-validate v1.0.1/go.mod h1:0vj8bNkYbSTNS2PIyH87K
github.com/envoyproxy/protoc-gen-validate v1.0.2/go.mod h1:GpiZQP3dDbg4JouG/NNS7QWXpgx6x8QiMKdmN72jogE=
github.com/envoyproxy/protoc-gen-validate v1.3.0 h1:TvGH1wof4H33rezVKWSpqKz5NXWg5VPuZ0uONDT6eb4=
github.com/envoyproxy/protoc-gen-validate v1.3.0/go.mod h1:HvYl7zwPa5mffgyeTUHA9zHIH36nmrm7oCbo4YKoSWA=
github.com/evstack/ev-node v1.1.0-rc.2 h1:7fdGpzjJwtNLtLJJ/Fyj2yFv5ARKnMAPh22Z5cRd1r0=
github.com/evstack/ev-node v1.1.0-rc.2/go.mod h1:5lIACV0hQGO5Btdb1b3fSw2Vz7Jvrg2yvMefalfWguA=
github.com/evstack/ev-node/core v1.0.0 h1:s0Tx0uWHme7SJn/ZNEtee4qNM8UO6PIxXnHhPbbKTz8=
github.com/evstack/ev-node/core v1.0.0/go.mod h1:n2w/LhYQTPsi48m6lMj16YiIqsaQw6gxwjyJvR+B3sY=
github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
Expand Down
Loading