Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughGo module dependencies across multiple applications are updated to bump Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @julienrbrt's task in 1m 1s —— View job Code Review: chore: prep rc.2
SummaryThis PR bumps Issues Found
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/grpc/go.mod`:
- Line 11: Remove or comment out the local replace directive that points
github.com/evstack/ev-node to a local ../../ path so the go.mod will resolve the
published RC version (github.com/evstack/ev-node v1.1.0-rc.2); locate the
replace block referencing github.com/evstack/ev-node and either delete it or
prefix it with // so the module uses the published v1.1.0-rc.2 for RC validation
and integration testing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5be11cd1-db1a-4be2-b614-b0a73626b5b3
⛔ Files ignored due to path filters (2)
apps/evm/go.sumis excluded by!**/*.sumtools/da-debug/go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
apps/evm/go.modapps/grpc/go.modapps/testapp/go.modtools/da-debug/go.mod
|
|
||
| require ( | ||
| github.com/evstack/ev-node v1.1.0-rc.1 | ||
| github.com/evstack/ev-node v1.1.0-rc.2 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether apps/grpc/go.mod still overrides bumped versions via local replace directives.
set -euo pipefail
file="apps/grpc/go.mod"
echo "Checking $file"
awk '
BEGIN { in_replace=0; found=0 }
/^replace[[:space:]]*\(/ { in_replace=1; next }
in_replace && /^\)/ { in_replace=0; next }
in_replace && $1=="github.com/evstack/ev-node" { found=1; print "ACTIVE replace:", $0 }
in_replace && $1=="github.com/evstack/ev-node/execution/grpc" { found=1; print "ACTIVE replace:", $0 }
END {
if (found==1) {
print "RESULT: active local replace entries exist; require version bumps are shadowed locally.";
exit 0;
} else {
print "RESULT: no active local replace entries for ev-node/grpc module paths.";
exit 1;
}
}
' "$file"Repository: evstack/ev-node
Length of output: 309
Remove or comment out local replace directives to enable RC version validation.
The active replace block (Lines 5-8) shadows the v1.1.0-rc.2 bump at Line 11, causing the module to use local paths (../../) instead of the published RC. This prevents RC integration testing for apps/grpc.
🔧 Suggested change (if RC validation from published modules is intended)
replace (
- github.com/evstack/ev-node => ../../
- github.com/evstack/ev-node/execution/grpc => ../../execution/grpc
+ // github.com/evstack/ev-node => ../../
+ // github.com/evstack/ev-node/execution/grpc => ../../execution/grpc
)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/grpc/go.mod` at line 11, Remove or comment out the local replace
directive that points github.com/evstack/ev-node to a local ../../ path so the
go.mod will resolve the published RC version (github.com/evstack/ev-node
v1.1.0-rc.2); locate the replace block referencing github.com/evstack/ev-node
and either delete it or prefix it with // so the module uses the published
v1.1.0-rc.2 for RC validation and integration testing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3231 +/- ##
==========================================
- Coverage 61.67% 61.64% -0.04%
==========================================
Files 120 120
Lines 12635 12635
==========================================
- Hits 7793 7789 -4
- Misses 3968 3971 +3
- Partials 874 875 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Overview
Summary by CodeRabbit
ev-nodemodule versions to release candidates