Skip to content

Conversation

@julienrbrt
Copy link
Member

Overview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJan 28, 2026, 9:50 AM

@claude
Copy link
Contributor

claude bot commented Jan 28, 2026

Claude finished @julienrbrt's task in 1m 20s —— View job


Code Review Complete

Review Tasks:

  • Read and analyze CHANGELOG.md changes
  • Review go.mod and go.sum dependency updates
  • Assess release preparation practices
  • Address existing review comments
  • Provide comprehensive feedback

Summary

This PR appropriately prepares the repository for the v1.0.0-rc.1 release by:

  1. Creating a new version section in CHANGELOG.md
  2. Upgrading the core module dependency from v1.0.0-beta.5 to v1.0.0-rc.1
  3. Removing the local replace directive, indicating the core module is now consumed as a published dependency

The changes are clean and follow standard release preparation practices. However, there are a few points to address.


Detailed Review

1. CHANGELOG.md Changes (CHANGELOG.md:10-18)

Positive:

  • Properly structured new version section for v1.0.0-rc.1
  • Fixed grammatical error: "This changes requires" → "This change requires" ✅
  • Added important clarification: "in node's genesis.json file" (was just "genesis.json file")
  • Added helpful context about feature enablement: "(enableable from rc.2)"
  • Formatting improvement with bold emphasis on breaking change warning

Issues Identified:

a) Typo: "stategies" → "strategies" (CHANGELOG.md:22)

- Add batching stategies (default stay time-based, unchanged with previous betas).

Should be:

- Add batching strategies (default stay time-based, unchanged with previous betas).

b) Version Section Name - Addressing tac0turtle's review comment
The reviewer asked "should we rc instead?" This likely refers to whether the section should be named:

  • Current: ## v1.0.0-rc.1
  • Alternative: ## v1.0.0-beta.12 (as mentioned in PR title)

Analysis: The PR title says "prep changelog" and mentions preparing for v1.0.0-beta.12, but the actual changes create a v1.0.0-rc.1 section. This appears intentional given that:

  • The go.mod dependency is upgraded to v1.0.0-rc.1
  • The core module has moved from beta to release candidate status
  • This aligns with the dependency upgrade in chore: bump to core rc.1 #3018

Recommendation: This is correct. The version should remain v1.0.0-rc.1 to match the core dependency version. However, the PR description should clarify this is for rc.1, not beta.12.

2. Dependency Management (go.mod:15, go.mod:188)

Positive:

  • ✅ Correctly upgrades core module from v1.0.0-beta.5 to v1.0.0-rc.1
  • ✅ Removes local replace directive (replace github.com/evstack/ev-node/core => ./core)
  • ✅ This signals the core module is now published and consumed as an external dependency
  • ✅ go.sum updated appropriately

Issues: None - this is the correct approach for release preparation.

3. Release Preparation Best Practices

Strengths:

  • Follows semantic versioning correctly (moving from beta to rc)
  • Changelog follows "Keep a Changelog" format
  • Breaking changes are properly marked with BREAKING prefix
  • PR references included for traceability
  • CI checks passing (Buf, tests, coverage)

Suggestions for Future Releases:

  1. Consider adding a release date to the version section once released
  2. Ensure the "Unreleased" section link at the bottom (CHANGELOG.md:181) is updated to point to the correct version comparison

Addressing Existing Review Comments

  1. Gemini's grammatical error fix - ✅ Already fixed in latest commit (a685118)
  2. tac0turtle's "should we rc instead?" question - Addressed above; current approach is correct

Additional Observations

Security: No security concerns. This is a documentation and dependency update only.

Testing: All CI checks pass. No code changes that would require additional testing.

Documentation: The changelog is clear and helpful. The breaking change warnings are appropriately emphasized.


Recommended Actions

  1. Fix the typo in CHANGELOG.md line 22: "stategies" → "strategies"
  2. Consider updating PR description to clarify this is preparing for v1.0.0-rc.1 (not beta.12)
  3. Merge when ready - the only blocker is the typo fix

Fix typo →


Verdict

Approve with minor fix needed

This is a well-executed release preparation PR. The only issue is a minor typo ("stategies"). Once fixed, this is ready to merge. The dependency upgrade and local replace removal are correctly handled for transitioning to a release candidate.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on release preparation by structuring the CHANGELOG.md for the upcoming v1.0.0-beta.12 release. It also updates a critical internal dependency, ev-node/core, to its release candidate version and removes its local replacement, streamlining the module's integration.

Highlights

  • Changelog Update: The CHANGELOG.md has been updated to include a new section for v1.0.0-beta.12, moving previously unreleased features under this specific version and adding minor clarifications.
  • Dependency Upgrade: The github.com/evstack/ev-node/core module dependency in go.mod has been upgraded from v1.0.0-beta.5 to v1.0.0-rc.1.
  • Local Module Replacement Removed: The local replace directive for github.com/evstack/ev-node/core in go.mod has been removed, indicating that the module is now being consumed as a published dependency rather than a local path.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@julienrbrt julienrbrt requested a review from tac0turtle January 28, 2026 09:14
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares the changelog for the v1.0.0-beta.12 release. The changes include updating CHANGELOG.md with the latest additions and modifications, and updating the go.mod and go.sum files to use a release candidate version of the core module while removing the local replace directive. The changes are straightforward and appropriate for a release preparation. I've found one minor typo in the changelog that should be corrected for clarity.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.55%. Comparing base (1b69313) to head (a685118).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
- Coverage   55.57%   55.55%   -0.02%     
==========================================
  Files         116      116              
  Lines       11477    11477              
==========================================
- Hits         6378     6376       -2     
- Misses       4400     4401       +1     
- Partials      699      700       +1     
Flag Coverage Δ
combined 55.55% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

julienrbrt and others added 2 commits January 28, 2026 10:49
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@julienrbrt julienrbrt merged commit 122486d into main Jan 28, 2026
16 of 19 checks passed
@julienrbrt julienrbrt deleted the julien/cl branch January 28, 2026 09:50
alpe added a commit that referenced this pull request Jan 28, 2026
* main:
  ci: strip app prefix (#3028)
  ci: fix release workflow (#3027)
  chore: prep apps (#3025)
  build: fix docker-compose for evm (#3022)
  chore: prepare execution release (#3021)
  chore: prep changelog (#3020)
  refactor(e2e): extract shared test helpers to DockerTestSuite (#3017)
  feat: High availabilty via RAFT (#2987)
  chore: bump to core rc.1 (#3018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants