Skip to content

ui: fix undefined and possibly-unbound variable bugs#1609

Open
jokujossai wants to merge 1 commit into
evilsocket:masterfrom
jokujossai:fix/ui-undefined-variables
Open

ui: fix undefined and possibly-unbound variable bugs#1609
jokujossai wants to merge 1 commit into
evilsocket:masterfrom
jokujossai:fix/ui-undefined-variables

Conversation

@jokujossai
Copy link
Copy Markdown

@jokujossai jokujossai commented May 28, 2026

Fixes a set of NameError-class bugs in the Python UI:

  • Undefined names (guaranteed crash): viewport_row, set_policy (wantedHook/wantedPolicy/rule), a duplicate get_node_chains returning an undefined rules, and a stale cb_signal.
  • Used-before-assignment on some paths: timeout in _show_systray_message; _action_* in the firewall context menu; interval for unknown downloader units; q in DB finally cleanups; base_query/qstr, cur_idx, rulesdir, tmpl/_title, pixmap.
  • pyinotify: guard usage on import availability via an identity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant