Skip to content

fix: typos#1345

Open
ddogfoodd wants to merge 1 commit into
evilsocket:masterfrom
ddogfoodd:fix-typos
Open

fix: typos#1345
ddogfoodd wants to merge 1 commit into
evilsocket:masterfrom
ddogfoodd:fix-typos

Conversation

@ddogfoodd
Copy link
Copy Markdown
Contributor

No description provided.

@tredondo
Copy link
Copy Markdown
Contributor

tredondo commented May 15, 2026

@gustavo-iniguez-goya seemed like an easy merge, maybe cherry-pick most of it?

@ddogfoodd
Copy link
Copy Markdown
Contributor Author

It's not that easy, as there are some merge conflicts already and probably even more when keeping other PRs in mind.

@tredondo
Copy link
Copy Markdown
Contributor

Hopefully other maintainers (if any?) can jump in and help with some of these PRs

@ddogfoodd
Copy link
Copy Markdown
Contributor Author

I took the time to rebase to upstream master, so merge conflicts should with master should be gone for now.
However, it should be noted that fixing typos is not really important and just a minor improvement (e.g. for very picky people reading the code). And merging this might create quite some merge conflicts on other PRs. They are easy to resolve but eat some time, so it's also reasonable to just ignore the typos and not merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants