feat(fetchers): enhance HackerNewsFetcher with timestamp display#90
Merged
feat(fetchers): enhance HackerNewsFetcher with timestamp display#90
Conversation
- Add time field deserialization from HN Firebase API - Display formatted UTC timestamp in item metadata - Add format_unix_timestamp() for epoch-to-ISO8601 conversion - Add tests: timestamp formatting, comments rendering, Ask HN posts Closes #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enhance HackerNewsFetcher with timestamp display and additional tests.
Why
Closes #58 — The HN Firebase API returns a
timefield (Unix timestamp) that was not being deserialized or displayed. This adds time information to the structured output.How
timefield to HNItem deserializationformat_unix_timestamp()for epoch-to-ISO8601 conversion (no external deps)Risk
Checklist