fix(builtins): enforce regex size limits in sed, grep, and awk#1049
Merged
fix(builtins): enforce regex size limits in sed, grep, and awk#1049
Conversation
Add build_regex() and build_regex_opts() helpers in search_common.rs that enforce 1MB size_limit and dfa_size_limit on all compiled regexes. Replace all Regex::new() and RegexBuilder::new() calls in sed.rs, grep.rs, awk.rs, and search_common.rs with these helpers. Closes #984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_regex()/build_regex_opts()helpers insearch_common.rsenforcing 1MB size and DFA limitsRegex::new()andRegexBuilder::new()calls in sed (3), grep (1), awk (8) with bounded helpersTest plan
match()Closes #984