fix(interpreter): support recursive function calls inside $() command substitution#1043
Merged
fix(interpreter): support recursive function calls inside $() command substitution#1043
Conversation
… substitution The expand_command_subs_in_arithmetic helper executed $() command substitutions without saving/restoring interpreter state (variables, arrays, functions, traps, etc.), unlike the regular CommandSubstitution handler. This caused variable mutations inside $() within $(()) to leak into the parent scope, breaking recursive function calls and violating subshell isolation semantics. Add save/restore of all mutable interpreter state around command substitution execution in expand_command_subs_in_arithmetic, matching the existing pattern in the WordPart::CommandSubstitution handler. Closes #962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$()command substitution that were silently failingexpand_command_subs_in_arithmeticexecuted$()without saving/restoring interpreter state, causing variable mutations to leak from subshell scopeCommandSubstitutionhandler patternTest plan
recursive_function_command_subst— factorial(5) = 120recursive_depth_3— nested string building via recursionrecursive_cmdsub_var_isolation— variable mutations inside$()in arithmetic don't leakCloses #962