Skip to content

fix(interpreter): remove exported vars from env on unset #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaliy merged 1 commit into from
Apr 3, 2026
+28 −0
Merged

fix(interpreter): remove exported vars from env on unset #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/bashkit/src/interpreter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4794,6 +4794,7 @@ impl Interpreter {
continue;
}
self.variables.remove(&resolved);
self.env.remove(&resolved);
self.arrays.remove(&resolved);
self.assoc_arrays.remove(&resolved);
for frame in self.call_stack.iter_mut().rev() {
Expand Down
27 changes: 27 additions & 0 deletions crates/bashkit/tests/spec_cases/bash/unset-exported-var.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
### unset_exported_variable
# unset should remove exported vars completely
export UNSET_TEST=value
unset UNSET_TEST
echo "${UNSET_TEST:-gone}"
### expect
gone
### end

### unset_then_check_defined
### skip: [[ -v VAR ]] unary operator not yet implemented
# unset var should not be -v defined
export UNSET_DEF_TEST=x
unset UNSET_DEF_TEST
[[ -v UNSET_DEF_TEST ]] && echo "still set" || echo "unset"
### expect
unset
### end

### unset_regular_variable
# unset non-exported var (verify no regression)
REGULAR=hello
unset REGULAR
echo "${REGULAR:-gone}"
### expect
gone
### end
Loading