feat: IRC server selection functionality#167
Draft
evan-buss wants to merge 21 commits intodevelopmentfrom
Draft
Conversation
This reverts commit a1b238c
- phosphor icons now uses a different package name - mantine notifications no longer need a wrapping provider
- added ability to sort individual columns
- moved column filtering to toolbar above grids
- design inspired by shadcn ui docs
- added global fuzzy search to search both author and title
- often times these aren't actually correct as IRC doesn't
give us these fields directly. we parse them based on
an assumed format that not all the IRC content
servers follow. As a result there are often times authors
in the title fields and titles in the authors field
- in the future I may merge the two into a single "identifier" field
- rewrote the grid components to use a reusable "DataTable"
component that abstracts all the nitty-gritty details
like cell virtualization and filtering / sorting logic
- this will make future changes much easier
- todo: toggle columns on / off for better mobile support
- can show / hide table columns so it better fits on various screen sizes - couldn't figure out a tanstack table way to responsively show / hide specific columns
- use the mantine scrollbars - adjust css to use full drawer height
feat: grid improvements
* feat: upgrade to mantine v7 - this version removes css in js so a lot of the custom styling had to be rewritten - theoretically it should be more performant than css-in-js - also updated the rest of the npm dependencies * fix: various analysis warnings - remove unused stuff * feat: various improvements - replace framer-motion with autoanimate. the framer motion bundle was not great as we are only using a single animation for add / remove from lists in 3 components. autoanimate is less than half the size of framer - add eslint config and fix any issues it reported - import mantine css for just the components we are using - this saved >200 kb from the bundle - fix some css issues to make it look like previous version
- currently, when the websocket connection is dropped, the irc connection is closed immediately. this change makes it so that after the websocket connection closed, the user has 3 minutes to reconnect before we close the irc connection. - the 3 minute 'self-destruct' is only triggered when the websocket is disconnected and is disabled once there is another connection - this should help with certain devices (such as iPad) where switching apps / tabs seems to close the websocket. i believe that the IRC server is sensitive to clients connecting/disconnecting too often and will ban users.
- forgot to delete file after removing framer-motion dependency
- had to `chmod +x .devcontainer/setup.sh` - also added `lazygit` to the pre-installed tools
- ideally, we'd have a version picker so we could preview the docs for the upcoming changes in development but it doesn't seem to be possible with the current gh-pages setup
feat: update to mkdocs 9
- need to handle edge cases and other polish
- remove --server / --tls flags from server as they are now passed from the browser client - update binary release workflow to latest go version - don't throw error if invalid flags are passed since --server / --tls were just removed we don't want users to upgrade and fail to start - add to changelog - better error message when TLS handshake fails - reorganize some state stuff into better file locations - add localstorage migration - refine server menu ui
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.