acp: advertise authMethods + handle authenticate#672
Open
iqdoctor wants to merge 2 commits intoevalstate:mainfrom
Open
acp: advertise authMethods + handle authenticate#672iqdoctor wants to merge 2 commits intoevalstate:mainfrom
iqdoctor wants to merge 2 commits intoevalstate:mainfrom
Conversation
- Advertise a minimal AuthMethod for ACP clients (agent default type per RFD)\n- Implement authenticate() handler (validates method id; no side effects yet)\n- Add/adjust ACP integration coverage\n- Add internal plan/survey docs for ACP registry + auth-methods
Contributor
Author
|
Note on the 2 new docs files in this PR:
If you'd prefer to keep PRs code-only, I'm fine dropping/moving these docs. |
Owner
|
Keep the plans in - at some point we should review them and turn them in to a code map for agents. Is there a good ACP Client to test this with? |
Contributor
Author
Also new ACP plugin for VS code coming soon:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
authMethodsentry from fast-agent ACP server (defaults toagenttype per the RFD when notypeis provided).authenticate(methodId)handler (validates method id; returns emptyAuthenticateResponse).agent_message_chunk).plan/acp-...).Why
ACP supports
authMethodsininitializeand anauthenticateRPC, but fast-agent currently returnsauthMethods=[]and does not implementauthenticate. The draft RFD proposes typed auth methods; until SDKs expose those fields, this keeps everything within the currentAuthMethodshape (id/name/description) and provides a stable hook for clients to trigger setup flows.Notes