Add more options for xmins and nextxids#63
Open
addisonj wants to merge 1 commit intoeulerto:masterfrom
Open
Conversation
This adds two more options for additional metadata into the slot: - `include-xmins` This data includes the `catalog_xmin` and `xmin` fields from the replication slot. The reasons for wanting this generally occurs when using logical replication with a secondary. Since replication slots don't get replicated to secondaries, in the event of the failover you need some mechanism for seeing what records you may have missed. The xmin/catalog_xmin is useful as you can use it for a lower bound and any records with a higher xmin could have been missed - `include-next-xids` This includes sending both the `epoch` and `nextxid` 32-bit ints. The epoch is a number that increments when xid rollover happens. This allows you to reconstruct the same txid you get from the `txid_current` function which accounts for rollover. This can be really useful to see at a point's time how far behind the slot you currently are.
Owner
|
@addisonj You submitted two features and it should be two pull requests or at least two commits. I saw that you change some unrelated lines, fix them. |
|
@addisonj: seems fair to pull apart the PR but I can definitely see the value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two more options for additional metadata into the slot:
include-xminsThis data includes thecatalog_xminandxminfieldsfrom the replication slot. The reasons for wanting this generally occurs when
using logical replication with a secondary. Since replication slots don't
get replicated to secondaries, in the event of the failover you need
some mechanism for seeing what records you may have missed. The
xmin/catalog_xmin is useful as you can use it for a lower bound and any
records with a higher xmin could have been missed
include-next-xidsThis includes sending both theepochandnextxid32-bit ints. The epoch is a number that increments when xidrollover happens. This allows you to reconstruct the same txid you get
from the
txid_currentfunction which accounts for rollover. This canbe really useful to see at a point's time how far behind the slot you
currently are.