Merged
Conversation
8 tasks
…/ethyca/fides into 3140-pbac-onboarding-empty-state
…fides into 3140-pbac-onboarding-empty-state
…/ethyca/fides into 3140-pbac-onboarding-empty-state
lucanovera
requested changes
Apr 7, 2026
Contributor
lucanovera
left a comment
There was a problem hiding this comment.
Nice work! The onboarding page looks good. I left a few comments about code improvements and to consider how to demo the feature.
- Rename "Policy config" to "Policy settings" in UI - Make onboarding page mirror main policies page layout - Add presets/industries endpoint to fetch industry options dynamically - Remove unused DATA_USE_ICON constant - Add /presets/ prefix to all onboarding-related endpoints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lucanovera
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3140
Description Of Changes
Add an onboarding form that appears as the empty state of the access policies list page. When no policies exist, users see a setup form where they select their industry and operating geographies, pick relevant data use categories, and optionally provide privacy policy documents. Submitting generates tailored access policies that populate the list.
Data use cards pull labels from the fideslang taxonomy via
useTaxonomies()so they stay in sync with the API. Mock handlers return industry-specific data use sets (7 per industry) with geography modifiers (EEA adds cookie/consent management, US adds targeted advertising).Also adds a "Policy config" modal accessible from the list page header for updating geographies and re-generating policies after initial setup.
Code Changes
OnboardingForm.tsx— New form component with industry/geography selects, data use card grid, policy URL/file upload, and generate buttonDataUseCard.tsx— Selectable card displaying a data use with icon and label from fideslang taxonomyPolicySettingsModal.tsx— Modal for updating geographies and uploading new policy docs post-setupPoliciesContainer.tsx— Show loading spinner during fetch, render onboarding form when no policies existpages/access-policies/index.tsx— Always show page description, conditionally show "Policy config" and "New policy" buttonsaccess-policies.slice.ts— AddgetOnboardingDataUses,getOnboardingConfig, andgeneratePoliciesendpointsconstants.ts— AddINDUSTRY_OPTIONSandDATA_USE_ICONmaptypes.ts— AddOnboardingFormState,OnboardingDataUsesResponse,OnboardingConfigResponse,GeneratePoliciesResponsemocks/onboarding-data.ts— Industry-to-fideslang data use mapping + geography modifiersmocks/generated-policies.ts— Mock generated policies with YAMLmocks/handlers.ts— MSW handlers for config, data-uses, and generate endpoints; policies start emptySteps to Confirm
/access-policieswith no existing policies — onboarding form should render inside the page contentPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works