chore(docker): run containers as non-root and pin base images by digest#252
Open
samcm wants to merge 2 commits into
Open
chore(docker): run containers as non-root and pin base images by digest#252samcm wants to merge 2 commits into
samcm wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the container images set a
USER, so they ran as root, and the distroless image usedstatic-debian11:latest(which also defaults to root). All base images used floating:latesttags.This switches the scratch image to
static-debian12:nonroot, adds a dedicated non-rootcheckpointzuser (uid 10001) to the debian and ubuntu images, and pins every base image by digest. The listen and metrics ports (5555/9090) are unprivileged, so dropping root needs no other changes.