Skip to content

Feat/add topup stamp info#108

Open
significance wants to merge 10 commits intoethersphere:mainfrom
significance:feat/add-topup-stamp-info
Open

Feat/add topup stamp info#108
significance wants to merge 10 commits intoethersphere:mainfrom
significance:feat/add-topup-stamp-info

Conversation

@significance
Copy link
Copy Markdown
Member

@significance significance commented Nov 28, 2025

@0xCardiE just mainly trying out flexing some ai coding here more than anything but i think could be useful if you're happy to merge. i took a look through and tidied up a little to made it a bit more palatable, the coding style i asked claude to mimic what is there before which i think it does a reasonable job of.

i have given the code a good scan but would be happy to read a bit more thoroughly and maybe give the ui a little more love before merge.

let me know your thoughts and if you feel like it's worthwhile to continue and/or there's anything you'd like changing i am happy to (ask claude to) do so 😀

@0xCardiE
Copy link
Copy Markdown
Collaborator

Adding visual here for others to see what is expected

image

@0xCardiE
Copy link
Copy Markdown
Collaborator

Seems nice, few questions.

  1. Dont know against which version was this built on, but current flow is that after topup, we go go front page and url without topup, yours currently goes back to topup. Maybe just needs a bump to main repo.
  2. No need to make fork in your repo, you can make PR in this repo
  3. Wondering do we need ticking timer? :) but i am fine with it
  4. The same with Balance in BZZ, nice that you pulled it out and calculated to BZZ, is there benefit of having it or is it more nice to have, also ok with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants