-
Notifications
You must be signed in to change notification settings - Fork 31
feat(redundancy): add redundancy level configuration for smoke check #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
e63ce38
08d39c4
199b519
a00ad6c
0dae27d
a9b0600
e801457
c14ea9b
5d5d384
1420fcf
47f4a1f
5581575
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ import ( | |
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/ethersphere/bee/v2/pkg/file/redundancy" | ||
| "github.com/ethersphere/bee/v2/pkg/swarm" | ||
| "github.com/ethersphere/beekeeper/pkg/bee" | ||
| "github.com/ethersphere/beekeeper/pkg/beekeeper" | ||
|
|
@@ -203,7 +204,8 @@ func (c *Check) run(ctx context.Context, cluster orchestration.Cluster, o Option | |
|
|
||
| c.logger.WithField("batch_id", batchID).Infof("node %s: using batch", uploader.Name()) | ||
|
|
||
| address, duration, err = test.Upload(ctx, uploader, txData, batchID) | ||
| rLevel := redundancy.NONE | ||
| address, duration, err = test.Upload(ctx, uploader, txData, batchID, &rLevel) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do not need to have default value for the rLevel, we should take it from configuration directly as is, to be backwards compatibile. If the rLevel is defined we should forward it. If not, use nil.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can set it to nil and later we do proper update to load check ? because it will require some modification to the check itself, wdyt ? |
||
| if err != nil { | ||
| c.metrics.UploadErrors.WithLabelValues(sizeLabel).Inc() | ||
| c.logger.Errorf("upload failed: %v", err) | ||
|
|
@@ -246,7 +248,8 @@ func (c *Check) run(ctx context.Context, cluster orchestration.Cluster, o Option | |
|
|
||
| c.metrics.DownloadAttempts.WithLabelValues(sizeLabel).Inc() | ||
|
|
||
| rxData, rxDuration, err = test.Download(ctx, downloader, address) | ||
| rLevel := redundancy.NONE | ||
| rxData, rxDuration, err = test.Download(ctx, downloader, address, &rLevel) | ||
|
akrem-chabchoub marked this conversation as resolved.
Outdated
|
||
| if err != nil { | ||
| c.metrics.DownloadErrors.WithLabelValues(sizeLabel).Inc() | ||
| c.logger.Errorf("download failed for size %d: %v", contentSize, err) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.