fix(addressbook): validate address entrie to prevent nil dereference#5534
Open
akrem-chabchoub wants to merge 2 commits into
Open
fix(addressbook): validate address entrie to prevent nil dereference#5534akrem-chabchoub wants to merge 2 commits into
akrem-chabchoub wants to merge 2 commits into
Conversation
acud
approved these changes
Jul 10, 2026
| return nil, false, err | ||
| } | ||
| if v.Address == nil { | ||
| return nil, false, ErrNotFound |
Contributor
There was a problem hiding this comment.
how about cleaning up the record while you're at it?
this returns "address not found", but leaves the db record corrupt
janos
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Nodes crash with panic error when connecting to peers if the addressbook contains corrupted entries with nil Address fields.
Added
nilcheck foraddressbefore returning itOpen API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure