fix(pseudosettle): bound first-contact allowance to connection time#5531
Open
mfw78 wants to merge 1 commit into
Open
fix(pseudosettle): bound first-contact allowance to connection time#5531mfw78 wants to merge 1 commit into
mfw78 wants to merge 1 commit into
Conversation
The time-based allowance a node grants an incoming refreshment is computed as (now - lastSettlementTime) * refreshRate. On the first refreshment from a peer there is no stored settlement time, so the anchor defaulted to the zero Unix epoch, making the allowance (now - 0) * refreshRate. This lets the very first refreshment forgive an effectively unbounded debt, decoupled from how long the peer has actually been connected. Anchor the first-contact allowance to the peer's connection time instead, so the initial refreshment only forgives debt accrued over the elapsed connected time. Subsequent settlements are unchanged.
Member
|
What about the payer side, should it match the peerAllowance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
On first contact with a peer, the pseudosettle time-based allowance was anchored to the zero Unix epoch instead of the peer's connection time, so the first refreshment could forgive an effectively unbounded debt.
peerAllowancecomputes the acceptable incoming payment as(now - lastSettlementTime) * refreshRate; with no stored settlement recordlastSettlementTimedefaulted to0, making the allowancenow * refreshRate.This records the connection time per peer in
initand anchors the first-contact allowance to it, so the initial refreshment only forgives debt accrued over the elapsed connected time. Subsequent settlements are unchanged.Opened as a draft pending team consensus on #5530, per the contributing guide.
Open API Spec Version Changes (if applicable)
None.
Motivation and Context (Optional)
See #5530.
Related Issue (Optional)
Closes #5530.
Screenshots (if appropriate):
N/A
AI Disclosure