chore: remove basic-ftp override — lockfile resolution is sufficient#7380
chore: remove basic-ftp override — lockfile resolution is sufficient#7380
Conversation
…ransitive dependency Co-authored-by: JohnMcLear <220864+JohnMcLear@users.noreply.github.com>
…ly basic-ftp 5.0.5→5.2.0 change Co-authored-by: JohnMcLear <220864+JohnMcLear@users.noreply.github.com>
|
@copilot The problem with this pull request is that it creates an exception for this package. I don't like it, shouldn't the upstream fix be implemented IE in live-plugin-manager → proxy-agent → pac-proxy-agent → get-uri or have we fixed the verison of one of those which is why it's not landed? |
…ge already allows 5.2.0 Co-authored-by: JohnMcLear <220864+JohnMcLear@users.noreply.github.com>
Is AI now contributing itself to our project. That's funny :) I don't really get what Copilot is trying to do. |
The override has been removed in d6be191. |
That makes sense. Thanks! |
|
@SamTV12345 The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
5 similar comments
|
@SamTV12345 The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@SamTV12345 The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@SamTV12345 The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@SamTV12345 The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@SamTV12345 The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
I didn't like it, it's unnecessary surgery that will be patched upstream and exposed 0 attack vectors to the software. Was unnecessary noise I should have probably just ignored :P |
The
pnpm.overridesexception forbasic-ftpis unnecessary.get-urialready declaresbasic-ftp@^5.0.2, which naturally satisfies5.2.0. The lockfile was simply frozen to5.0.5from a previous install; updating the pinned version directly is the correct fix.Changes
package.json: Remove thepnpm.overridesblock forbasic-ftppnpm-lock.yaml: Remove theoverridessection;basic-ftpresolves to5.2.0via the existing^5.0.2range inget-uriDependency chain for reference:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.