docs: modernize CONTRIBUTING.md for plugin scope#110
Merged
Conversation
Replaces the etherpad-lite-era boilerplate with a plugin-specific guide: target branch is main, local install via pnpm run plugins i --path, tests run via the etherpad harness, and i18n/a11y are now standing requirements.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
ether/etherpad-lite's package.json declares packageManager: pnpm@11.0.6. pnpm/action-setup@v6 errored with ERR_PNPM_BAD_PM_VERSION when version was pinned to 10 because the action saw the conflict with the core's packageManager field. Bumping the pin to 11 resolves the mismatch.
Pinning pnpm version on the action while ether/etherpad-lite's package.json has "packageManager": "pnpm@11.0.6" triggers ERR_PNPM_BAD_PM_VERSION regardless of the pinned value. Drop the version pin and point the action at the core's package.json so it reads the canonical version from packageManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the fleet-wide plugin docs modernization (pilot: ether/ep_align#182).
CONTRIBUTING.mdfor plugin scope (target branchmain, plugin install viapnpm run plugins i --path, i18n + a11y are standing requirements). Cross-links to ether/etherpad's CONTRIBUTING.md for shared rules.Out of scope (separate campaigns)