Use static list of keys in model

[serathius]

Continuation of #19973
PoC for #21133

After improvements in #21488

goos: linux
goarch: amd64
pkg: go.etcd.io/etcd/tests/v3/robustness/validate
cpu: AMD Ryzen Threadripper PRO 3945WX 12-Cores     
                                                               │   old.txt    │               new.txt               │
                                                               │    sec/op    │   sec/op     vs base                │
ValidateLinearizableOperations/SequentialSuccessPuts-24           17.14m ± 3%   15.09m ± 3%  -11.97% (p=0.000 n=10)
ValidateLinearizableOperations/SequentialFailedPuts-24            15.68m ± 2%   10.89m ± 1%  -30.57% (p=0.000 n=10)
ValidateLinearizableOperations/ConcurrentFailedPutsWithRead-24    16.61m ± 2%   12.92m ± 2%  -22.23% (p=0.000 n=10)
ValidateLinearizableOperations/ConcurrentFailedPuts-24            18.42m ± 1%   12.09m ± 3%  -34.38% (p=0.000 n=10)
ValidateLinearizableOperations/BacktrackingHeavy-24              26.638m ± 1%   1.521m ± 1%  -94.29% (p=0.000 n=10)
geomean                                                           18.54m        8.284m       -55.32%

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.37%. Comparing base (59a250f) to head (711d868).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21486      +/-   ##
==========================================
+ Coverage   68.30%   68.37%   +0.06%     
==========================================
  Files         429      429              
  Lines       35389    35389              
==========================================
+ Hits        24172    24196      +24     
+ Misses       9809     9785      -24     
  Partials     1408     1408              

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a250f...711d868. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[serathius]

/retest

[serathius]

/test pull-etcd-robustness-amd64
/test pull-etcd-robustness-arm64

[serathius]

/cc @nwnt @henrybear327
Should be good to review.

[serathius]

Extracted #21578

[serathius]

PTAL @nwnt @henrybear327 @fuweid

[nwnt]

Not sure if I'm making things too complicated just to avoid the duplication...

Suggested change

	if !ok {
	var previousValueErrField *zap.Field
	switch {
	case !ok:
	previousValueErrField = &zap.Any("previousValue", nil)
	case *event.PrevValue != *val:
	previousValueErrField = &zap.Any("previousValue", nil)
	}
	if previousValueErrField != nil {
	lg.Error("Incorrect event prevValue field", zap.Int("client", report.ClientID), zap.Any("event", event), zap.Any("previousValue", *previousValueErrField))
	}

[nwnt]

meant to highlight the whole if/else statement.

[serathius]

Let's not mix refactor and feature work.

[serathius]

Extracted #21597 to make review easier.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henrybear327, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment