Skip to content

Fix ignored header in framework e2e client#21103

Merged
serathius merged 1 commit intoetcd-io:mainfrom
nwnt:fix-e2e-ignored-resp-count
Jan 13, 2026
Merged

Fix ignored header in framework e2e client#21103
serathius merged 1 commit intoetcd-io:mainfrom
nwnt:fix-e2e-ignored-resp-count

Conversation

@nwnt
Copy link
Copy Markdown
Member

@nwnt nwnt commented Jan 10, 2026

Fix the cause of e2e failures from #21025. The count is basically ignored in the current logic and always returned as 0.

@serathius

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.82%. Comparing base (6ba1214) to head (99fea53).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21103      +/-   ##
==========================================
- Coverage   68.33%   67.82%   -0.52%     
==========================================
  Files         429      429              
  Lines       35244    35244              
==========================================
- Hits        24083    23903     -180     
- Misses       9767     9934     +167     
- Partials     1394     1407      +13     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba1214...99fea53. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwnt nwnt force-pushed the fix-e2e-ignored-resp-count branch from edfd5e1 to 0768602 Compare January 11, 2026 05:13
@nwnt
Copy link
Copy Markdown
Member Author

nwnt commented Jan 11, 2026

Fixed the e2e failures. Ready for a review now.

Comment thread tests/framework/e2e/etcdctl.go Outdated
@nwnt nwnt force-pushed the fix-e2e-ignored-resp-count branch from 0768602 to 3217eed Compare January 12, 2026 04:21
@nwnt nwnt force-pushed the fix-e2e-ignored-resp-count branch from 3217eed to eb93178 Compare January 12, 2026 04:26
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx

Comment thread tests/framework/e2e/etcdctl.go Outdated
@nwnt nwnt force-pushed the fix-e2e-ignored-resp-count branch from eb93178 to 61631b9 Compare January 12, 2026 14:18
Comment thread tests/framework/e2e/etcdctl.go Outdated
@serathius
Copy link
Copy Markdown
Member

Thanks, last nit, let's update the function name too.

Signed-off-by: Nont <nont@duck.com>
@nwnt nwnt force-pushed the fix-e2e-ignored-resp-count branch from 61631b9 to 99fea53 Compare January 12, 2026 16:35
@serathius
Copy link
Copy Markdown
Member

/retest

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit f5e6640 into etcd-io:main Jan 13, 2026
32 checks passed
@nwnt nwnt deleted the fix-e2e-ignored-resp-count branch January 13, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants