Fix ignored header in framework e2e client#21103
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 30 files with indirect coverage changes @@ Coverage Diff @@
## main #21103 +/- ##
==========================================
- Coverage 68.33% 67.82% -0.52%
==========================================
Files 429 429
Lines 35244 35244
==========================================
- Hits 24083 23903 -180
- Misses 9767 9934 +167
- Partials 1394 1407 +13 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
edfd5e1 to
0768602
Compare
|
Fixed the e2e failures. Ready for a review now. |
0768602 to
3217eed
Compare
3217eed to
eb93178
Compare
eb93178 to
61631b9
Compare
|
Thanks, last nit, let's update the function name too. |
Signed-off-by: Nont <nont@duck.com>
61631b9 to
99fea53
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix the cause of e2e failures from #21025. The count is basically ignored in the current logic and always returned as 0.
@serathius