Simplify running tests

[ivanvc]

After working on the issues from #21033 (and because I initially translated the old function in #20872), I realized we can simplify test execution: in the Go workspace, we don't need to iterate over packages.

So, this pull request:

• Removes iteration over packages; with the Go workspace, we don't need to iterate.
• Replaces KEEP_GOING_TESTS behavior by using the Go -failfast test flag.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.37%. Comparing base (65b1be4) to head (64f366f).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21095      +/-   ##
==========================================
- Coverage   68.48%   68.37%   -0.11%     
==========================================
  Files         429      429              
  Lines       35281    35244      -37     
==========================================
- Hits        24162    24098      -64     
- Misses       9717     9748      +31     
+ Partials     1402     1398       -4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b1be4...64f366f. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ahrtr]

Not sure why remove this for loop? Previously it may run test against a list of package, now you remove it? If you remove the for loop, do we still need to the variable packages (see line 389 or 385),

etcd/scripts/test_lib.sh

Line 389 in 30f9ac5

local packages=()

[ahrtr]

I see the explanation Removes iteration over packages; with the Go workspace, we don't need to iterate.. If it's correct behaviour, the variable packages mentioned above should be removed as well.

[ivanvc]

Good catch. I initially had more changes in this pull request and decided to keep only the one to remove the for loop (ref: https://github.com/etcd-io/etcd/pull/21073/files), but I forgot to apply them. Updating.

[ivanvc]

Re: removing the for loop, I probably didn't give enough context. But with #21033, it made me realize that we never actually use the test mode where we expand the passed packages (Robustness tests were the only ones using this behavior), and again, with the Go workspace, if we don't need to expand them, there's no benefit to iterating over the packages; it only complicates the code.

[k8s-ci-robot]

@ivanvc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-coverage-report	64f366f	link	true	/test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• scripts/OWNERS [ahrtr,ivanvc,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment