feat: Migrate to espressif/release-sign action for signing Windows binaries#7
feat: Migrate to espressif/release-sign action for signing Windows binaries#7peterdragun merged 1 commit intomasterfrom
Conversation
👋 Hello peterdragun, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Pull request overview
This PR migrates from a custom PowerShell script-based code signing solution to the espressif/release-sign GitHub Action for signing Windows binaries. The change replaces the direct certificate/password approach with Azure Key Vault-based signing using Azure service principal credentials.
Key Changes:
- Replaced
certificateandcertificate-passwordinputs with five Azure-related inputs (azure-client-id,azure-client-secret,azure-tenant-id,azure-keyvault-uri,azure-keyvault-cert-name) - Removed the custom
Sign-File.ps1PowerShell script - Updated signing workflow to use
espressif/release-sign@masteraction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| action.yml | Updated input parameters from certificate-based to Azure Key Vault credentials; replaced custom PowerShell signing logic with espressif/release-sign action |
| Sign-File.ps1 | Removed custom PowerShell signing script (no longer needed) |
| README.md | Updated documentation to reflect new Azure-based signing approach with examples and parameter descriptions |
Critical Issues Identified:
- The default values for Azure credential inputs reference
secretscontext which is not accessible in composite actions, causing them to always be empty strings - The action uses
@masterbranch reference which is not recommended for production stability - Documentation incorrectly states that defaults work automatically when they require explicit passing from workflows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f787b2b to
5059035
Compare
fa2def5 to
ce238f5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ce238f5 to
3de7dde
Compare
|
@jakub-kocka PTAL |
3de7dde to
299924d
Compare
jakub-kocka
left a comment
There was a problem hiding this comment.
LGTM! Thanks, Peter, I have left just a thought.
Description
Use https://github.com/espressif/release-sign for signing istead of custom powershell script. This will require follow-up MRs in case of esptool and esp-idf-monitor, as the names of the secrets has changed and cannot be defined globally in this repository.
Internal Tracker
Testing