feat: Replace ppa/deadsnakes with uv#5
Conversation
👋 Hello peterdragun, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the deadsnakes PPA repository no longer supports Ubuntu 20.04 (required for GLIBC compatibility) by replacing it with pyenv for Python installation. The change ensures continued compatibility with the required Ubuntu version while maintaining the same functionality.
Key changes:
- Replace deadsnakes PPA with pyenv for Python installation
- Add environment variables to prevent interactive prompts during apt-get operations
- Update Python executable references from versioned to generic
pythoncommand
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7921500 to
25b0a6c
Compare
dobairoland
left a comment
There was a problem hiding this comment.
LGTM with one suggestion. uv replaces many tools and is much faster. I think projects like this offer a good chance to experiment with such tools.
This can be merged as is.
05b818d to
55b5203
Compare
96336fe to
cd4ce7d
Compare
9fe399c to
bdad7df
Compare
bdad7df to
46eff52
Compare
|
Hi @dobairoland thank you for the recommendation to use uv, seems much better than pyenv in terms of performance. We got to roughly the same performance as before! I have updated the code to use the uv everywhere (it took me a couple of iterations to make it work 😅, but I think it was worth it!). Test results have also been updated. Please take a look. BTW, should I also bump the default Python version to 3.14? What do you think? |
dobairoland
left a comment
There was a problem hiding this comment.
LGTM.
BTW, should I also bump the default Python version to 3.14? What do you think?
I think can we can wait with that for the next time when there will already be some bugfix releases for it.
5e5b074 to
eea7e33
Compare
eea7e33 to
1496ebe
Compare
radimkarnis
left a comment
There was a problem hiding this comment.
uv solution LGTM as well.
Description
Deadsnake repository stopped supporting Ubuntu 20.04 (see deadsnakes/issues#251), which is required because of the GLIBC version (see espressif/esptool#1100). So this MR is fixing the issue with building the esptool by replacing the deadsnakes with uv. I have also replaced all pip calls with uv, which seems to speed up the process quite a bit.
I have also noticed that sometimes during
apt-get update -ythere is an interactive prompt for time zone info - I have disabled this by setting the noninteractive mode and timezone to UTC.Failed job: https://github.com/espressif/esptool/actions/runs/18274789103/job/52027147066
Tested in: https://github.com/peterdragun/esptool/actions/runs/18279077745
Related
No related issues
Checklist
Before submitting a Pull Request, please ensure the following: