Skip to content

fix: Use image from wheels for ARMv7 builds#10

Merged
peterdragun merged 1 commit intomasterfrom
fix/use_wheels_image
Mar 31, 2026
Merged

fix: Use image from wheels for ARMv7 builds#10
peterdragun merged 1 commit intomasterfrom
fix/use_wheels_image

Conversation

@peterdragun
Copy link
Copy Markdown
Collaborator

@peterdragun peterdragun commented Mar 25, 2026

Description

We had an issue with building esptool on armv7. The main issue was uv downloading the incorrect wheel from our index, and that failed on the wrong version of OpenSSL, see: https://github.com/espressif/esptool/actions/runs/22508432922/job/65212183798

This is a workaround for this issue. If we are going to use the same image that was used to generate the wheel, this should be more stable. Also, this should improve the performance since we don't need to install packages on every run (to be fair, there was a cache anyway, but having it in one place in docker image is nicer)

Related

  • internal tracker: ESPTOOL-1286

Testing

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello peterdragun, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against ea45871

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the composite GitHub Action’s ARMv7 build path to run inside the same container image used to build/publish the ARMv7 wheels, aiming to avoid uv selecting incompatible wheels (e.g., OpenSSL mismatch) and to reduce per-run dependency setup.

Changes:

  • Switch ARMv7 builds from uraimo/run-on-arch-action@v3 to a direct docker run on ghcr.io/espressif/.../idf-python-wheels-armv7l:v1.
  • Add QEMU setup (docker/setup-qemu-action@v3) for ARMv7 Docker execution.
  • Update documentation and input descriptions to reflect that the ARMv7 image already contains most build dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
action.yml Reworks ARMv7 build execution to run inside the wheels image, adds QEMU setup, and updates ARM package input docs.
README.md Updates ARMv7 usage examples and input table to match the new ARMv7 image assumptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@peterdragun peterdragun force-pushed the fix/use_wheels_image branch from 92ad2ae to 4c8fb52 Compare March 26, 2026 09:08
@peterdragun peterdragun requested a review from jakub-kocka March 30, 2026 13:30
Copy link
Copy Markdown

@jakub-kocka jakub-kocka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @peterdragun, for this fix! LGTM.

I am also mentioning related PR here, which introduces an updated approach to building the cPython packages and esptool dependencies: espressif/idf-python-wheels#63

@peterdragun peterdragun force-pushed the fix/use_wheels_image branch from 4c8fb52 to ea45871 Compare March 31, 2026 08:14
@peterdragun peterdragun merged commit f96fc05 into master Mar 31, 2026
2 checks passed
@peterdragun peterdragun deleted the fix/use_wheels_image branch March 31, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants