use 1.94 in CI by MabezDev · Pull Request #5110 · esp-rs/esp-hal

MabezDev · 2026-03-04T10:27:46Z

Note: regenerate the api baseline for esp-bootloader-idf once merged.

MabezDev · 2026-03-04T10:27:55Z

/hil full

github-actions · 2026-03-04T10:28:58Z

Triggered full HIL run for #5110.

Run: https://github.com/esp-rs/esp-hal/actions/runs/22665349586

Status update: ❌ HIL (full) run failed (conclusion: failure).

SergioGasquez

We should also update https://github.com/esp-rs/esp-hal/blob/main/.github/workflows/pre-rel-check.yml#L28, I think we forgot to bump it to 1.93 last time

Copilot

Pull request overview

This PR updates the pinned esp-rs/xtensa-toolchain version used by GitHub Actions workflows to 1.94.0.0, keeping CI and auxiliary automation aligned with the intended Xtensa Rust toolchain revision.

Changes:

Bump Xtensa toolchain pin from 1.93.0.0 to 1.94.0.0 across multiple CI workflows.
Update API baseline generation/check workflows to use the new Xtensa toolchain pin.
Update the shared composite action used for building tests to use the new Xtensa toolchain pin.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.github/workflows/documentation.yml	Pins Xtensa toolchain used during documentation builds to `1.94.0.0`.
.github/workflows/ci.yml	Pins Xtensa toolchain used in CI (xtensa matrix group) to `1.94.0.0`.
.github/workflows/ci-nightly.yml	Pins Xtensa toolchain used in nightly CI job(s) to `1.94.0.0`.
.github/workflows/binary-size.yml	Pins Xtensa toolchain used for size analysis runs to `1.94.0.0`.
.github/workflows/api-baseline-generation.yml	Pins Xtensa toolchain used for baseline generation to `1.94.0.0`.
.github/workflows/api-baseline-check.yml	Pins Xtensa toolchain used for baseline checks to `1.94.0.0`.
.github/actions/build-tests/action.yml	Pins Xtensa toolchain used by the composite “build tests” action to `1.94.0.0`.

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

JurajSadel · 2026-03-04T13:05:02Z

I guess we will also have to update

esp-hal/xtask/Cargo.toml

Line 44 in 8f0ceab

cargo-semver-checks = { version = "0.46.0", optional = true }

and regenerate the baselines.

MabezDev · 2026-03-04T13:29:29Z

I guess we will also have to update

esp-hal/xtask/Cargo.toml

Line 44 in 8f0ceab

cargo-semver-checks = { version = "0.46.0", optional = true }

and regenerate the baselines.

0.46 is the latest

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

bjoernQ · 2026-03-04T14:16:30Z

Maybe we could document (in the feature docs) that print-logs-from-driver now requires 1.94

(or the build.rs could check that and give an error 🤔 )

github-actions · 2026-03-05T11:34:05Z

New commits in main has made this PR unmergable. Please resolve the conflicts.

MabezDev · 2026-03-05T15:52:24Z

/hil full

github-actions · 2026-03-05T15:53:34Z

Triggered full HIL run for #5110.

Run: https://github.com/esp-rs/esp-hal/actions/runs/22726076313

Status update: ⚠️ HIL (full) run was cancelled.

MabezDev · 2026-03-05T15:56:40Z

/hil full

github-actions · 2026-03-05T15:57:51Z

Triggered full HIL run for #5110.

Run: https://github.com/esp-rs/esp-hal/actions/runs/22726267839

Status update: HIL (full) run is still in progress or status unknown.

MabezDev · 2026-03-17T09:51:43Z

Rebased, reworked and updated to 1.94.0.2. I think this should be good to go now. Just a reminder that we need to regenerate the baselines after this PR.

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

bugadani · 2026-03-17T09:54:33Z

/hil full

github-actions · 2026-03-17T09:55:36Z

Triggered full HIL run for #5110.

Run: https://github.com/esp-rs/esp-hal/actions/runs/23188430490

Status update: HIL (full) run is still in progress or status unknown.

github-actions · 2026-03-19T14:42:20Z

New commits in main has made this PR unmergable. Please resolve the conflicts.

VaListImpl was renamed to VaList in the latest esp toolchain. Add a qa-test exercising the print-logs-from-driver feature.

MabezDev · 2026-03-26T10:04:29Z

hil commands won't work on PRs like these, because they're launched from main. I started a manual run here: https://github.com/esp-rs/esp-hal/actions/runs/23588284153

I think before we merge this, we should add a skip-semver-checks label, instead of using the breaking change label. The rationale is that the breaking change label will regenerate the semver checks from that commit, when in reality, on a compiler upgrade, we should be generating the baseline from the same tag/commit as it was before.

MabezDev · 2026-03-26T10:05:11Z

Another option is that for PRs like these, we skip the MQ and merge it manually.

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

github-actions · 2026-03-27T09:04:55Z

New commits in main has made this PR unmergable. Please resolve the conflicts.

MabezDev added skip-changelog No changelog modification needed breaking-change-esp-hal Contains esp-hal breaking changes labels Mar 4, 2026

Copilot AI review requested due to automatic review settings March 4, 2026 10:27

Copilot started reviewing on behalf of MabezDev March 4, 2026 10:28 View session

SergioGasquez reviewed Mar 4, 2026

View reviewed changes

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

MabezDev mentioned this pull request Mar 4, 2026

use VaList instead of VaListImpl (nightly update) esp-rs/esp-wifi-sys#497

Merged

Copilot AI review requested due to automatic review settings March 4, 2026 12:36

Copilot started reviewing on behalf of MabezDev March 4, 2026 12:36 View session

bugadani reviewed Mar 4, 2026

View reviewed changes

Comment thread qa-test/src/bin/wifi_syslog.rs

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Comment thread esp-radio/src/wifi/os_adapter/mod.rs

Copilot AI review requested due to automatic review settings March 4, 2026 13:43

Copilot started reviewing on behalf of MabezDev March 4, 2026 13:44 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

bugadani reviewed Mar 4, 2026

View reviewed changes

Comment thread qa-test/src/bin/wifi_syslog.rs Outdated

MabezDev marked this pull request as draft March 4, 2026 14:45

github-actions Bot added the merge-conflict Merge conflict detected. Automatically added/removed by CI. label Mar 5, 2026

MabezDev force-pushed the use-1.94-in-ci branch from 62a87ef to d9d1276 Compare March 5, 2026 15:51

github-actions Bot removed the merge-conflict Merge conflict detected. Automatically added/removed by CI. label Mar 5, 2026

MabezDev force-pushed the use-1.94-in-ci branch from d9d1276 to 1c081cc Compare March 5, 2026 15:56

Copilot AI reviewed Mar 17, 2026

View reviewed changes

bugadani approved these changes Mar 17, 2026

View reviewed changes

github-actions Bot added the merge-conflict Merge conflict detected. Automatically added/removed by CI. label Mar 19, 2026

MabezDev added 7 commits March 26, 2026 09:49

use 1.94 in CI

1154a76

use updated sys

477c348

fix VaListImpl rename and add wifi_syslog qa-test

75a88e2

VaListImpl was renamed to VaList in the latest esp toolchain. Add a qa-test exercising the print-logs-from-driver feature.

only build qa syslog test on xtensa

09e316c

fmt

70c4af1

fix qa test, add vaarg hil test

499d13b

use 1.94.0.2

d91f5a3

MabezDev force-pushed the use-1.94-in-ci branch from 2c29d7b to d91f5a3 Compare March 26, 2026 09:57

github-actions Bot removed the merge-conflict Merge conflict detected. Automatically added/removed by CI. label Mar 26, 2026

MabezDev removed the breaking-change-esp-hal Contains esp-hal breaking changes label Mar 26, 2026

update sys

0afd756

Copilot AI review requested due to automatic review settings March 26, 2026 11:50

Copilot started reviewing on behalf of MabezDev March 26, 2026 11:52 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

github-actions Bot added the merge-conflict Merge conflict detected. Automatically added/removed by CI. label Mar 27, 2026

MabezDev marked this pull request as draft April 8, 2026 10:04

MabezDev mentioned this pull request Apr 8, 2026

Add a skip-semver-checks label #5313

Closed

MabezDev closed this Apr 16, 2026

MabezDev mentioned this pull request Apr 16, 2026

Add syslog qa test #5381

Merged

MabezDev deleted the use-1.94-in-ci branch April 16, 2026 10:19

Conversation

MabezDev commented Mar 4, 2026

Uh oh!

MabezDev commented Mar 4, 2026

Uh oh!

github-actions Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SergioGasquez left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

JurajSadel commented Mar 4, 2026

Uh oh!

MabezDev commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

bjoernQ commented Mar 4, 2026

Uh oh!

github-actions Bot commented Mar 5, 2026

Uh oh!

MabezDev commented Mar 5, 2026

Uh oh!

github-actions Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MabezDev commented Mar 5, 2026

Uh oh!

github-actions Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MabezDev commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bugadani commented Mar 17, 2026

Uh oh!

github-actions Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2026

Uh oh!

MabezDev commented Mar 26, 2026

Uh oh!

MabezDev commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Mar 4, 2026 •

edited

Loading

github-actions Bot commented Mar 5, 2026 •

edited

Loading

github-actions Bot commented Mar 5, 2026 •

edited

Loading

github-actions Bot commented Mar 17, 2026 •

edited

Loading