iperf_auth: check BIO_read return value in Base64Decode#2040
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the PR! We'll take a look at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On malformed base64 input (e.g. the 2-char string "AB"), BIO_read in
Base64Decode returns -1, which is assigned to the size_t out-parameter
*length and silently becomes SIZE_MAX while the function still returns
0. Callers in iperf_auth.c (decode_auth_setting, load_pubkey_from_base64)
then pass that huge length downstream. Check the BIO_read result, free
the buffer and report failure if it is negative.