Skip to content

Conversation

@Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Nov 30, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR migrates the Playground to be compatible with ESLint v10. The main issue is that ESLint v10 removes the Linter#getRules() API, which the Playground currently uses to get core rules metadata. Additionally, @typescript-eslint/scope-manager (which is used by @typescript-eslint/parser) doesn't yet implement the new interface required by ESLint v10, causing ESLint to crash when TypeScript code is analyzed in the Playground.

What changes did you make? (Give an overview)

  • Added a postinstall script that generates rules_meta.json containing metadata for all ESLint core rules, and modified the Playground to load rule metadata from the generated JSON file instead of using Linter#getRules().
  • Created a temporary patch for @typescript-eslint/parser (copied from the main repository) that adds the missing addGlobals() method to the scope manager.

Related Issues

Fixes #854

Is there anything you'd like reviewers to focus on?

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/new-eslint/deploys/695dc256b7324a00083a9538
😎 Deploy Preview https://deploy-preview-853--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/ja-eslint/deploys/695dc2564dccd70008b9b6d3
😎 Deploy Preview https://deploy-preview-853--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/hi-eslint/deploys/695dc256d659480008fa3d12
😎 Deploy Preview https://deploy-preview-853--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/zh-hans-eslint/deploys/695dc256acbb0d00081547de
😎 Deploy Preview https://deploy-preview-853--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/pt-br-eslint/deploys/695dc257f940cb00084a152e
😎 Deploy Preview https://deploy-preview-853--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/fr-eslint/deploys/695dc257bc24630008337290
😎 Deploy Preview https://deploy-preview-853--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/de-eslint/deploys/695dc25735b38b0008715379
😎 Deploy Preview https://deploy-preview-853--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit dd46635
🔍 Latest deploy log https://app.netlify.com/projects/es-eslint/deploys/695dc256681ca50008e1674d
😎 Deploy Preview https://deploy-preview-853--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Dec 1, 2025
@Pixel998 Pixel998 mentioned this pull request Dec 20, 2025
1 task
},
"dependencies": {
"eslint": "latest"
"eslint": "10.0.0-beta.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to revert this when eslint v10 is released, and to not merge this PR before this is updated.

@Pixel998
Copy link
Contributor Author

This should be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

Suggestion: Prepare Playground for ESLint v10.0.0

5 participants