-
-
Notifications
You must be signed in to change notification settings - Fork 74
feat: migrate playground to ESLint v10 #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }, | ||
| "dependencies": { | ||
| "eslint": "latest" | ||
| "eslint": "10.0.0-beta.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to revert this when eslint v10 is released, and to not merge this PR before this is updated.
|
This should be ready for review. |
Prerequisites checklist
What is the purpose of this pull request?
This PR migrates the Playground to be compatible with ESLint v10. The main issue is that ESLint v10 removes the
Linter#getRules()API, which the Playground currently uses to get core rules metadata. Additionally,@typescript-eslint/scope-manager(which is used by@typescript-eslint/parser) doesn't yet implement the new interface required by ESLint v10, causing ESLint to crash when TypeScript code is analyzed in the Playground.What changes did you make? (Give an overview)
rules_meta.jsoncontaining metadata for all ESLint core rules, and modified the Playground to load rule metadata from the generated JSON file instead of usingLinter#getRules().@typescript-eslint/parser(copied from the main repository) that adds the missingaddGlobals()method to the scope manager.Related Issues
Fixes #854
Is there anything you'd like reviewers to focus on?