Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Fix Camelcase allow type#278

Open
eMerzh wants to merge 1 commit intoeslint-types:mainfrom
eMerzh:patch-1
Open

Fix Camelcase allow type#278
eMerzh wants to merge 1 commit intoeslint-types:mainfrom
eMerzh:patch-1

Conversation

@eMerzh
Copy link
Copy Markdown

@eMerzh eMerzh commented Mar 20, 2024

as described here
https://eslint.org/docs/latest/rules/camelcase#options

the type should be a list of string

@eMerzh eMerzh requested a review from Shinigami92 as a code owner March 20, 2024 14:54
@Shinigami92
Copy link
Copy Markdown
Member

Shinigami92 commented Mar 21, 2024

Please check

https://github.com/eslint/eslint/blob/b91f9dc072f17f5ea79803deb86cf002d031b4cf/lib/rules/camelcase.js#L48-L57

and if it is correctly

The rule types are generated from these schematas

@eMerzh
Copy link
Copy Markdown
Author

eMerzh commented Mar 21, 2024

oooh 🤔 maybe it's the translation that is wrong 🤔

bc

items: [
                            {
                                type: "string"
                            }
                        ]

i guess it means an array of string?

@eMerzh
Copy link
Copy Markdown
Author

eMerzh commented Mar 21, 2024

but open upstream bcherny/json-schema-to-typescript#584

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants