Skip to content

Updates#12

Merged
DenysGonchar merged 2 commits intomasterfrom
updates
Feb 21, 2025
Merged

Updates#12
DenysGonchar merged 2 commits intomasterfrom
updates

Conversation

@NelsonVides
Copy link
Copy Markdown
Contributor

@NelsonVides NelsonVides commented Feb 21, 2025

stringprep new version loads x100 faster at startup, super important! 😄

Then the optimised from_binary splits the binary parts in around 6x less reductions for inputs of any size (note, BEAM reductions). Honestly in wall-clock measurements, the difference is unnoticeable unless the input gets very big. At the maximum allowed size for JIDs, that is, 1023 chars per each of the three parts, we get ~10% faster at best. Not a big diff, but well, not a big PR either 🤷🏽

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (398e31a) to head (65e077a).

Files with missing lines Patch % Lines
src/jid.erl 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   97.00%   95.16%   -1.84%     
==========================================
  Files           1        1              
  Lines         100      124      +24     
==========================================
+ Hits           97      118      +21     
- Misses          3        6       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DenysGonchar DenysGonchar merged commit d21aca7 into master Feb 21, 2025
@DenysGonchar DenysGonchar deleted the updates branch February 21, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants