Updates#12
Merged
DenysGonchar merged 2 commits intomasterfrom Feb 21, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 97.00% 95.16% -1.84%
==========================================
Files 1 1
Lines 100 124 +24
==========================================
+ Hits 97 118 +21
- Misses 3 6 +3 ☔ View full report in Codecov by Sentry. |
DenysGonchar
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stringprepnew version loads x100 faster at startup, super important! 😄Then the optimised
from_binarysplits the binary parts in around 6x less reductions for inputs of any size (note, BEAM reductions). Honestly in wall-clock measurements, the difference is unnoticeable unless the input gets very big. At the maximum allowed size for JIDs, that is, 1023 chars per each of the three parts, we get ~10% faster at best. Not a big diff, but well, not a big PR either 🤷🏽