feat: add stream-buffers to replacements#395
Open
gameroman wants to merge 6 commits intoes-tooling:mainfrom
Open
feat: add stream-buffers to replacements#395gameroman wants to merge 6 commits intoes-tooling:mainfrom
stream-buffers to replacements#395gameroman wants to merge 6 commits intoes-tooling:mainfrom
Conversation
gameroman
changed the title
stream-buffers to replacementsstream-buffers to replacements
43081j
reviewed
Mar 9, 2026
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
43081j
reviewed
Mar 10, 2026
docs/modules/stream-buffers.md
Outdated
Comment on lines
+21
to
+22
| const out = sink.getContents() // or sink.getContentsAsString('utf8') / JSON.parse(sink.getContentsAsString('utf8')) / new Blob([sink.getContents()]) / sink.getContents().buffer.slice(...) [!code --] | ||
| const out = await buffer(readable) // or text(readable) / json(readable) / blob(readable) / arrayBuffer(readable) [!code ++] |
Contributor
There was a problem hiding this comment.
these comments don't make much sense for a diff. a diff is meant to show before/after. if that's not possible, we shouldn't bother with a diff.
nobody would write this code, which is why it doesn't work as a diff. without the comments it'd be fine, or don't use a diff
Contributor
Author
There was a problem hiding this comment.
Thank you, will change that
I will take a look into top dependents to understand how it is usually used
Top dependents
| # | Downloads/month | Traffic | Version | Package |
|---|---|---|---|---|
| 1 | 14.90M | 95.07 GB | 2.2.x | bplist-creator |
| 2 | 4.02M | 25.67 GB | ^3.0.2 | @kubernetes/client-node |
| 3 | 2.80M | 17.85 GB | ^3.0.2 | @wdio/local-runner |
| 4 | 607.85k | 3.88 GB | ^3.0.0 | shrink-ray-current |
| 5 | 539.09k | 3.44 GB | 3.0.3 | @cdktf/cli-core |
| 6 | 314.31k | 2.00 GB | ^3.0.2 | grunt-contrib-compress |
| 7 | 219.30k | 1.40 GB | 1.0.1 | pngjs-image |
| 8 | 89.52k | 571.06 MB | ^0.2.3 | connect-injector |
| 9 | 68.38k | 436.22 MB | ^3.0.3 | @anolilab/multi-semantic-release |
| 10 | 40.18k | 256.33 MB | ^3.0.3 | multi-semantic-release |
Contributor
Author
There was a problem hiding this comment.
I did some analysis and looks like most (or many) downloads are coming from expo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242
Closes #244
Closes e18e/e18e#110