Skip to content

feat: add string.prototype.repeat to replacements#383

Merged
43081j merged 6 commits intoes-tooling:mainfrom
gameroman:native/string.prototype.repeat
Mar 3, 2026
Merged

feat: add string.prototype.repeat to replacements#383
43081j merged 6 commits intoes-tooling:mainfrom
gameroman:native/string.prototype.repeat

Conversation

@gameroman
Copy link
Contributor

No description provided.

@gameroman gameroman changed the title add string.prototype.repeat to replacements feat: add string.prototype.repeat to replacements Mar 2, 2026
@43081j
Copy link
Contributor

43081j commented Mar 2, 2026

This diff looks wrong. Bunch of removed things and what not

Maybe fix the conflicts and see if it's any better

@gameroman
Copy link
Contributor Author

gameroman commented Mar 2, 2026

This diff looks wrong. Bunch of removed things and what not

I moved two native replacements, that for some reason were in micro-utilities.json, to native.json

@43081j
Copy link
Contributor

43081j commented Mar 2, 2026

because they are polyfills for native functionality, they belong in the native manifest

e.g. is-finite is a polyfill for isFinite

it isn't a micro-utility because of that

@gameroman
Copy link
Contributor Author

because they are polyfills for native functionality, they belong in the native manifest

e.g. is-finite is a polyfill for isFinite

it isn't a micro-utility because of that

Yeah, that's exactly why I moved it from micro-utilities.json to native.json here

43081j
43081j previously approved these changes Mar 3, 2026
@43081j
Copy link
Contributor

43081j commented Mar 3, 2026

my mistake, i misread.

can you fix the conflicts?

@gameroman gameroman requested a review from 43081j March 3, 2026 11:00
@43081j 43081j merged commit d53e5a6 into es-tooling:main Mar 3, 2026
3 checks passed
@gameroman gameroman deleted the native/string.prototype.repeat branch March 3, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants