Add extended tests for defineProperty#355
Open
Xotic750 wants to merge 1 commit intoes-shims:masterfrom
Open
Conversation
Member
There was a problem hiding this comment.
in what JS engine is (1.) distinct from (1) in any way, shape, or form???
Contributor
Author
There was a problem hiding this comment.
Probably none, I blindly ported everything and as I mentioned, some of this needs thinning out. A lot of my tests are if you don't try it then you will never know, but that's how I manage to find some of this stuff. ;)
61dacff to
5684c6e
Compare
5684c6e to
f0022e6
Compare
f0022e6 to
70bf1ba
Compare
70bf1ba to
48e7123
Compare
Member
|
@Xotic750 can you please check the "allow edits" checkbox on the RHS of the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE7 & 8, Safari 6, 7, 8 & 9, Chrome 26, 27, Node 0.8 & 0.10 all failed some of these tests.
Some versions of
eslintalso have a problem when linting these tests.The tests could use a little thinning out, and could give better detail of the problem. Some tests for default properties and if they work (on native) would probably also be nice.
Of course, failures here also generally mean failures in
definePropertiesaswell.