refactor: route all log writes through a single LogWriter#14
Merged
Conversation
ernolf
commented
Jul 18, 2026
ernolf
commented
Owner
- the format switch, json encoding and locked append existed four times across the middleware and CountingStream; they now live once in LogWriter::write()
- a failed write logs one warning per process instead of being silently swallowed
- writeImmediate() reuses the already compacted response headers from the meta array instead of compacting the raw ones a third time
- adjust the writeImmediate unit test to the narrowed signature
- the format switch, json encoding and locked append existed four times across the middleware and CountingStream; they now live once in LogWriter::write() - a failed write logs one warning per process instead of being silently swallowed - writeImmediate() reuses the already compacted response headers from the meta array instead of compacting the raw ones a third time - adjust the writeImmediate unit test to the narrowed signature Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.