feat: redact credential-bearing query parameters in logged URIs#13
Merged
Conversation
ernolf
commented
Jul 18, 2026
ernolf
commented
Owner
- values of access_token, api_key, apikey, auth, client_secret, password, secret, signature, token and the X-Amz-* presign triple are always logged as [redacted]; matching is case-insensitive, parameter names and the rest of the URI stay unchanged
- new system config audit_http_client_redact_params extends the built-in list; the defaults have no opt-out
- document the new config key in the README
…secrets) - values of access_token, api_key, apikey, auth, client_secret, password, secret, signature, token and the X-Amz-* presign triple are always logged as [redacted]; matching is case-insensitive, parameter names and the rest of the URI stay unchanged - path portions matching configurable PCRE patterns are redacted too; the built-in pattern covers Google's private-<hash> iCal segments, invalid patterns are skipped - new system configs audit_http_client_redact_params and audit_http_client_redact_path_patterns extend the built-in lists; the defaults have no opt-out - document both new config keys in the README Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
ernolf
force-pushed
the
ernolf/feat/redact-query-params
branch
from
July 18, 2026 23:26
ed12300 to
900d06b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.