Skip to content

Support Node 24 runtime#426

Merged
paulo-ferraz-oliveira merged 1 commit intoerlef:mainfrom
levibuzolic:levi/node24-support
Mar 27, 2026
Merged

Support Node 24 runtime#426
paulo-ferraz-oliveira merged 1 commit intoerlef:mainfrom
levibuzolic:levi/node24-support

Conversation

@levibuzolic
Copy link
Copy Markdown
Contributor

@levibuzolic levibuzolic commented Mar 11, 2026

Description

Update the action runtime, engine constraint, and CI workflow pins from Node 20 to Node 24 per GitHub's guidance on the deprecation of Node 20 on GitHub Actions runners: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

To align with other GitHub actions it'd probably make sense to release this under a new major version.

Update the action runtime, engine constraint, and CI workflow pins from Node 20 to Node 24 per GitHub's guidance on the deprecation of Node 20 on GitHub Actions runners: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
@paulo-ferraz-oliveira
Copy link
Copy Markdown
Collaborator

Is this breaking for the consumer? What's the consequence of just moving versions to the one that'll come after this PR is accepted?

@paulo-ferraz-oliveira
Copy link
Copy Markdown
Collaborator

new major version

Is it absolutely necessary and/or breaking? We don't wanna bump for the sake of it, but only if required.

If, at the same time this is being accepted, support is also dropped for older runners, I'm Ok to not bump major.

@starbelly, @wojtekmach, any ideas?

@levibuzolic
Copy link
Copy Markdown
Contributor Author

Could see reasons both for and against. But really this should be all completely unnoticeable to downstream users, so just a regular version bump is probably fine. 👍

@paulo-ferraz-oliveira
Copy link
Copy Markdown
Collaborator

I'll wait on further feedback. If we deem it breaking we will want to respect versioning, but if it's not (or e.g. GitHub only supports 24+ is their own runners) then it should be fine to just bump minor.

@PJUllrich
Copy link
Copy Markdown

Small FYI: GitHub will force-run this action on Node 24 from June 2nd, 2026 onward (https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/). Ideally, a v2 running on Node 24 would be released before that date so that we can test it out before it becomes compulsory.

@paulo-ferraz-oliveira
Copy link
Copy Markdown
Collaborator

a v2 running on Node 24

We've stayed away from moving to v2 in the past for similar reasons (I'm not really sure how this would break, though). As soon as I have feedback from other maintainers we'll move this forward.

@wojtekmach
Copy link
Copy Markdown
Collaborator

I'm fine with either, I'd personally keep it as v1 as node 20 will be defunct in a few months anyway.

@paulo-ferraz-oliveira
Copy link
Copy Markdown
Collaborator

Ok, let's go v1 then. I agree with what you say, and if it's failing for newer releases developers can most likely pin it to whatever is the current version.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit d5f3979 into erlef:main Mar 27, 2026
71 checks passed
@paulo-ferraz-oliveira
Copy link
Copy Markdown
Collaborator

ℹ️ This has been released in v1.24.0.

v1.24 was moved to accompany this tag, as was v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action needs to be upgraded to node24

6 participants