Inline Documentation and memory-efficient array added#21
Open
sbshah97 wants to merge 16 commits intoerilyth:masterfrom
sbshah97:master
Open
Inline Documentation and memory-efficient array added#21sbshah97 wants to merge 16 commits intoerilyth:masterfrom sbshah97:master
sbshah97 wants to merge 16 commits intoerilyth:masterfrom
sbshah97:master
Conversation
Closed
Owner
|
@salman-bhai Could you please split this up into multiple PRs. Also in general it is preferred to have global declarations of arrays instead of passing them as parameters, so please don't make them local. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline Documentation: Comments have been added within the code to increase the readabilty of the code
Memory Efficient Array: A memory efficient array has been added instead of declaring a Global variable for the array-type.