Release v1.11.2#347
Merged
Merged
Conversation
The v1.11.1 release attempt exposed two bugs in the VSIX step added in #344: 1. The "Warn if SSMS extension build failed" step had `(issue #343)` in a single-line `run:` value. YAML treated ` #343)"` as a comment, leaving pwsh an unterminated string. The step failed, and because it was not continue-on-error it failed the whole job - skipping signing, Velopack, and every artifact upload. v1.11.1 was created empty and has been deleted. 2. The VSIX build itself failed: `msbuild -t:Restore,Build` evaluates the project once before Restore writes the package-generated props, so VSToolsPath never got redirected into the Microsoft.VSSDK.BuildTools package and the VSSDK targets could not be found (MSB4226). Fixes: - Build the VSIX with `msbuild -restore -t:Build` so Restore runs in its own evaluation and the VSSDK targets resolve without the VS workload. - Remove the separate warn step. The build step now only sets a `BUILT` output on success and the upload is gated on it - nothing in the SSMS path can fail the job anymore. - Drop non-ASCII characters from the run-block strings. - Bump version to 1.11.2 (1.11.1 is burned). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-attempt of the SSMS VSIX release test. v1.11.1 failed (empty release, deleted) due to a YAML comment bug and a VSIX build issue — both fixed in #346.
The release step can no longer fail the job, so this release completes cleanly whether or not the VSIX build succeeds. The
-restorefix for the VSIX is the real test here.See #346 for the full post-mortem.
🤖 Generated with Claude Code