Fix two post-split UX issues (schema lookup on Run Repro, toolbar overflow)#335
Merged
Conversation
Both are pre-existing bugs surfaced during smoke-testing of the god-file split; neither was caused by the move-only refactor. 1. Run Repro from a file-loaded plan produced an actual-plan tab with schema lookups (Show Indexes / Show Table Definition) greyed out. The new PlanViewerControl wasn't given the connection used to run the repro. Now inherits ConnectionString + connection services + status, matching the query-editor Run Repro path. 2. QuerySessionControl toolbar overflowed off-screen on narrow windows — the Format / Format Options buttons were unreachable. Switched the toolbar from a single-row StackPanel to a WrapPanel so buttons wrap to a second row instead of being cut off. Build clean: 0 errors on PlanViewer.sln. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing UX bugs surfaced during smoke-testing of the god-file split PRs (#327–#334). Neither was caused by the move-only refactor — they were latent in the original code.
Schema lookups greyed out after Run Repro from a file-loaded plan. When you File → Open an estimated plan and click Run Repro, the resulting actual-plan tab had Show Indexes / Show Table Definition disabled on the node context menu. The freshly-created
PlanViewerControlwasn't given the connection used to run the repro. Now it inheritsConnectionString+SetConnectionServices+SetConnectionStatus, matching the query-editor Run Repro path (which already did this).QuerySessionControl toolbar overflowed off-screen on narrow windows. The Format / Format Options buttons (and more, on a sufficiently narrow window) were cut off and unreachable. Switched the toolbar from a single-row
StackPanelto aWrapPanelso buttons wrap to a second row instead of being clipped.Test plan
dotnet build PlanViewer.sln— 0 errors🤖 Generated with Claude Code