Skip to content

Revert File I/O label change (premature) #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Mar 19, 2026
Merged

Revert File I/O label change (premature) #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lite/Services/RemoteCollectorService.FileIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ private static (string DatabaseName, string FileName, string FileType, string Ph
int DatabaseId, int FileId) ReadFileIoRow(SqlDataReader reader)
{
return (
DatabaseName: reader.IsDBNull(0) ? $"DB_{reader.GetValue(13)}" : reader.GetString(0),
FileName: reader.IsDBNull(1) ? $"File_{reader.GetValue(14)}" : reader.GetString(1),
FileType: reader.IsDBNull(2) ? "UNKNOWN" : reader.GetString(2),
DatabaseName: reader.IsDBNull(0) ? "Unknown" : reader.GetString(0),
FileName: reader.IsDBNull(1) ? "Unknown" : reader.GetString(1),
FileType: reader.IsDBNull(2) ? "Unknown" : reader.GetString(2),
PhysicalName: reader.IsDBNull(3) ? "" : reader.GetString(3),
SizeMb: reader.IsDBNull(4) ? 0m : reader.GetDecimal(4),
NumOfReads: reader.IsDBNull(5) ? 0L : reader.GetInt64(5),
Expand Down
52 changes: 17 additions & 35 deletions install/08_collect_query_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,38 +222,6 @@ BEGIN
row_hash binary(32) NULL
);

/*
Pre-build list of ONLINE, accessible database IDs.
This prevents any downstream DMV calls (dm_exec_sql_text,
dm_exec_plan_attributes) from touching RESTORING databases
on passive mirror servers — which triggers severity 22 dumps.
*/
CREATE TABLE
#online_databases
(
database_id integer NOT NULL PRIMARY KEY,
database_name sysname NOT NULL
);

INSERT INTO
#online_databases
(
database_id,
database_name
)
SELECT
d.database_id,
d.name
FROM sys.databases AS d
WHERE d.state = 0
AND HAS_DBACCESS(d.name) = 1
AND d.database_id NOT IN
(
1, 2, 3, 4, 32761, 32767,
DB_ID(N'PerformanceMonitor')
)
AND d.database_id < 32761;

INSERT INTO
#query_stats_staging
(
Expand Down Expand Up @@ -306,7 +274,7 @@ BEGIN
)
SELECT
server_start_time = @server_start_time,
database_name = od.database_name,
database_name = d.name,
sql_handle = qs.sql_handle,
statement_start_offset = qs.statement_start_offset,
statement_end_offset = qs.statement_end_offset,
Expand Down Expand Up @@ -385,9 +353,23 @@ BEGIN
qs.statement_start_offset,
qs.statement_end_offset
) AS tqp
INNER JOIN #online_databases AS od
ON st.dbid = od.database_id
CROSS APPLY
(
SELECT
dbid = CONVERT(integer, pa.value)
FROM sys.dm_exec_plan_attributes(qs.plan_handle) AS pa
WHERE pa.attribute = N'dbid'
) AS pa
INNER JOIN sys.databases AS d
ON pa.dbid = d.database_id
WHERE qs.last_execution_time >= @cutoff_time
AND d.state = 0 /*ONLINE only — skip RESTORING databases (mirroring/AG secondary)*/
AND pa.dbid NOT IN
(
1, 2, 3, 4, 32761, 32767,
DB_ID(N'PerformanceMonitor')
)
AND pa.dbid < 32761 /*exclude contained AG system databases*/
OPTION(RECOMPILE);

/*
Expand Down
Loading