Lite: Dismiss Selected clears the server-tab badge too (#1092)#1122
Merged
Conversation
Dismiss All already fired AlertsDismissed to acknowledge the matching server-tab alert badge(s); Dismiss Selected did not, so the badge stayed lit after dismissing individual rows. Fire AlertsDismissed for each distinct server represented in the dismissed rows -- selected rows can span servers when the filter is "all" -- matching Dismiss All's behavior. Completes the #1092 badge-clearing work (core fixed in #1100). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1092 — "Dismiss Selected" didn't clear the server-tab badge
The core badge-clearing work shipped in #1100 (click-to-acknowledge badge, Dismiss All, context-menu Acknowledge). One gap remained: Dismiss Selected dismissed the rows but never fired
AlertsDismissed, so the server-tab badge stayed lit after dismissing individual alerts.Fix
After a successful Dismiss Selected, fire
AlertsDismissedfor each distinct server represented in the dismissed rows — selected rows can span servers when the filter is "all" — reusing the same host handler (OnAlertHistoryDismissed→AcknowledgeServerBadge) that Dismiss All already uses. 6 lines, 1 file.Validation
Lite.Tests: 434/434.🤖 Generated with Claude Code