cl/fork: remove dead fork version length check#18888
Closed
MoNyAvA wants to merge 3 commits intoerigontech:mainfrom
Closed
cl/fork: remove dead fork version length check#18888MoNyAvA wants to merge 3 commits intoerigontech:mainfrom
MoNyAvA wants to merge 3 commits intoerigontech:mainfrom
Conversation
domiwei
approved these changes
Feb 3, 2026
AskAlexSharov
approved these changes
Feb 5, 2026
Collaborator
|
🤖 Closed by automated review. This PR appears to be an AI-generated stylistic/convention change (dead code removal, unused variable cleanup, redundant code removal) from a non-core contributor. These types of changes are not being accepted at this time. If you believe this was closed in error, please reach out to a maintainer. |
auto-merge was automatically disabled
February 17, 2026 19:55
Pull request was closed
Collaborator
|
[SharovBot] 🤖 Closed by automated review. This PR appears to be an AI-generated stylistic/convention change (dead code removal, unused variable cleanup, redundant code removal) from a non-core contributor. These types of changes are not being accepted at this time. If you believe this was closed in error, please reach out to a maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domain was performing a length check on a slice derived from common.Bytes4 ([4]byte), so len(forkVersion) was always 4 and the error branch was unreachable. This added noise without providing any real safety
Simplified Domain to work directly with the fixed-size [4]byte fork versions (PreviousVersion / CurrentVersion) and removed the unreachable length check, keeping the external behavior and error handling otherwise unchanged