This repository was archived by the owner on Jul 31, 2025. It is now read-only.
updated comments for createEIP712AuthMessageSigner function#12
Open
Alison024 wants to merge 2 commits intoerc7824:mainfrom
Open
updated comments for createEIP712AuthMessageSigner function#12Alison024 wants to merge 2 commits intoerc7824:mainfrom
Alison024 wants to merge 2 commits intoerc7824:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
domainmust matchauthRequestMsg.app_name.createAuthRequestMessageJSDoc comments to markscopeandapplicationas optional parameters.Message to the team
Your project is fantastic—truly a potential game-changer for GameFi. I have a couple of suggestions that could make the developer experience even smoother:
SDK consistency
It would help to standardize on a single library for types and signing utilities. The current mix of Viem and
ethers@5.7.2means developers sometimes have to juggle both sets of types.Session-signing guide
A short external guide on generating and signing session keys/messages would be invaluable for new contributors.
Keep up the great work, and best of luck from the Sentia team!